New function_return_linter()
#1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering whether we should centralize this to |
|
Good point -- do we have any other linters in the package yet under this umbrella? Smaller point -- what about |
|
Just glancing over the list, I also see we could put this under |
IndrajeetPatil
changed the title
function_return_linter()
Comment on lines
+37
to
+45
| expect_lint( | ||
| trim_some(" | ||
| foo <- function(x) { | ||
| return(x <<- x + 1) | ||
| } | ||
| "), | ||
| lint_msg, | ||
| linter | ||
| ) |
There was a problem hiding this comment.
Also add this one for the sake of completeness?
library(lintr)
lint(
text = "foo <- function(x) {
return(x + 1 ->> x)
}
",
linters = function_return_linter()
)
#> <text>:2:16: warning: [function_return_linter] Move the assignment outside of the return() clause, or skip assignment altogether.
#> return(x + 1 ->> x)
#> ^~~~~~~~~~~Created on 2022-09-30 with reprex v2.0.2
IndrajeetPatil
approved these changes
Sep 30, 2022
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #884